fix QT>=6.4 segfault by always setting surface type #984
+0
−2
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #754 for details but this is the recommendation from QT dev @alpqr that 100% WFM. Note, as I mention there officially the old behavior would be best replicated by setting this to the internal value
QSurface::RasterGLSurface
from https://doc.qt.io/qt-6/qsurface.html#SurfaceType-enum as this is what QT 6.3 and lower did. If you want me to update the PR to that I can. I don't have osx to test there.Clearly people are running mythtv with QT > 6.3 so I am not sure why only some users hit this bug. Maybe it is only if they have hardware rendering enabled? Given how long it has stood though there must be something scoping it to just a select few of us.
Checklist
Fixes #754